Initial work towards supporting Groups v2 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubdos
reviewed
Mar 2, 2021
rubdos
reviewed
Mar 3, 2021
rubdos
reviewed
Mar 3, 2021
rubdos
reviewed
Mar 3, 2021
rubdos
reviewed
Mar 3, 2021
What about having everything in |
That, or modeled after |
gferon
changed the title
rubdos
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I open this PR so we can start discussing about the general direction we want to take for this change.
Expect: dirty code, hacks, ugly things and... being able to fetch the metadata of a group v2 given that you posses its
master_key(which is part of what the client receives on every new message).I'd mostly like to get some early review, and answers to the following questions:
CredentialsCacheok? (It's modeled after the cache used in the Java source code)awc::Clientsets theAuthorizationheader twice if it's set at the client and request level, so I had to remove it fromget_clientand set it manually everywhere. This is error prone, but I couldn't think of another way.unwrap()in this change? 💝TODO: